dietpi-sync dry run option not working

Having issues with your DietPi installation, or, found a bug? Post it here.
Post Reply
WilburWalsh
Posts: 12
Joined: Sat Dec 22, 2018 1:33 pm

dietpi-sync dry run option not working

Post by WilburWalsh »

Hi,

first of all I want to thank the developers of DietPi for their amazing work. A couple of days ago I digged out my old RPi 1 and came across your site while searching for an adequate distro. Since then I have been playing around with it and setup my system. Mostly everything worked out fine straight away. Good job, guys!

So, now regarding the problem: Today I wanted to setup a backup of my system and started dietpi-sync. After setting the configurations to my needs, I wanted to check with a dry run and used that option from within dietpi-sync. After some strange error messages at the start of the run and rsync actually copying files, I checked your script and found a bug in the way you set up the rsync options:

Code: Select all

			#Rsync options
			local rync_options+="-aHP4 --info=name0 --info=progress2 --human-readable --delete-excluded --exclude-from=$FP_FILTER_INCLUDE_EXCLUDE --log-file=$FP_LOG "

			# - Compression?
			if (( $SYNC_COMPRESSION )); then

				rync_options+='z'

			fi

			# - Dry Run?
			if (( $SYNC_DRY_RUN )); then

				rync_options+='n'

			fi

			# - Delete mode?
			if (( $SYNC_DELETE_MODE )); then

				rync_options+=' --delete'

			fi
By simply adding 'z' and/or 'n' to the options string you mess everything up, because now there is no more leading '-'. Seems to me as those options were forgotten when you re-arranged the options string at some point. Changing the 'n' to ' --dry-run' fixed it for me.

Oh, I'm running on v6.19.7 | RPi B (armv6l)

I hope this is some useful information for you. Thanks again for the great work!
User avatar
MichaIng
Site Admin
Posts: 2423
Joined: Sat Nov 18, 2017 6:21 pm

Re: dietpi-sync dry run option not working

Post by MichaIng »

@WilburWalsh
Many thanks for your report. Damn this bug was already introduced on v6.15: https://github.com/Fourdee/DietPi/commi ... 35cfb5fa47
- And no one recognized until now... We really need to merge dietpi-sync and dietpi-backup into one script...

Will be fixed with v6.20!
PR is up: https://github.com/Fourdee/DietPi/pull/2366
- Some other enhancements are inside.

Would be great if you can help testing it bullet prove:

Code: Select all

wget https://raw.githubusercontent.com/Fourdee/DietPi/dietpi-sync/dietpi/dietpi-sync -O /DietPi/dietpi/dietpi-sync
chmod +x /DietPi/dietpi/dietpi-sync
WilburWalsh
Posts: 12
Joined: Sat Dec 22, 2018 1:33 pm

Re: dietpi-sync dry run option not working

Post by WilburWalsh »

@MichaIng
Tested it and works fine here in both dry run and real run situations.

But I‘m afraid a typo sneeked in in line 279:

Code: Select all

		(( $SYNC_CRONDAILY )) && YNC_CRONDAILY_TEXT='[On]'
The Sync Daily Menu Item thus always shows „Off“ even it was enabled.
User avatar
MichaIng
Site Admin
Posts: 2423
Joined: Sat Nov 18, 2017 6:21 pm

Re: dietpi-sync dry run option not working

Post by MichaIng »

@WilburWalsh
Thanks for testing.

Jep thanks, missing "S" :o
WilburWalsh
Posts: 12
Joined: Sat Dec 22, 2018 1:33 pm

Re: dietpi-sync dry run option not working

Post by WilburWalsh »

Hi @MichaIng ,

I‘m afraid there is another problem. Just checked whether the daily sync worked, and it did not :?
The dietpi cron.daily script checks line 5 of the dietpi-sync_settings file, but after removing the compression flag from it, there are only 4 lines left in that file, so that check fails.

Anyway, enjoy your holidays, I will be enjoying mine :) and probably not be able to test the next couple of days.
User avatar
MichaIng
Site Admin
Posts: 2423
Joined: Sat Nov 18, 2017 6:21 pm

Re: dietpi-sync dry run option not working

Post by MichaIng »

Jep, just patched all other occurrences within code: https://github.com/Fourdee/DietPi/pull/ ... 148d853492
Post Reply