Issue with Homer Theme Documentation (Closed)

Greetings,

While installing Homer this evening, I noticed that the Documentation for the ‘Theming - macOS’ was causing a bit of an issue due to capitalization and the /tmp directory path.

After a bit of editing, I found the issues - unfortunately, I am not as fluent as I would like to be with GitHub, so I didn’t do a pull request (I think that is the right terminology) to have this approved for change. Additionally, I added the “Light” Wallpaper as well.

Please see below for a BEFORE and AFTER:

Before:

cd /tmp
curl -fLO 'https://github.com/walkxcode/homer-theme/archive/main.tar.gz'
tar xf main.tar.gz
rm main.tar.gz
cp Homer-Theme-main/custom.css /var/www/homer/assets/custom.css
cp Homer-Theme-main/wallpaper.jpeg /var/www/homer/assets/wallpaper.jpeg
cp -R Homer-Theme-main/fonts /var/www/homer/assets/
rm -R Homer-Theme-main

After:

cd /tmp
curl -fLO 'https://github.com/walkxcode/homer-theme/archive/main.tar.gz'
tar xf main.tar.gz
rm main.tar.gz
cp /tmp/homer-theme-main/assets/custom.css /var/www/homer/assets/custom.css
cp /tmp/homer-theme-main/assets/wallpaper.jpeg /var/www/homer/assets/wallpaper.jpeg
cp /tmp/homer-theme-main/assets/wallpaper-light.jpeg /var/www/homer/assets/wallpaper-light.jpeg
cp -R /tmp/homer-theme-main/assets/fonts /var/www/homer/assets/
rm -R /tmp/homer-theme-main

This can probably be optimized a little better, but at least it’s a starting point.

Just to avoid a misunderstanding, actually we don’t install any theme or wallpaper at all. This is what we do only.

 DietPi-Software
─────────────────────────────────────────────────────
 Step: Installing Homer: Simple HOMepage for your servER to keep your services on hand

[  OK  ] DietPi-Software | cd /tmp/DietPi-Software
[  OK  ] DietPi-Software | curl -sSfL https://github.com/bastienwirtz/homer/releases/latest/download/homer.zip -o homer.zip
[  OK  ] DietPi-Software | unzip -o homer.zip -dhomer
[  OK  ] DietPi-Software | rm homer.zip
[  OK  ] DietPi-Software | cp -a homer/. /var/www/homer/
[  OK  ] DietPi-Software | rm -R homer
[  OK  ] DietPi-Software | cp /var/www/homer/assets/config.yml.dist /var/www/homer/assets/config.yml

So you request is to add themes and wallpapers to the installation?

I think he is referring to our docs, where theming is covered.
But it would be enough to change the capitalization, no need to referr to the full path since the first command is cd /tmp.
This should be enough:

cd /tmp
curl -fLO 'https://github.com/walkxcode/homer-theme/archive/main.tar.gz'
tar xf main.tar.gz
rm main.tar.gz
cp homer-theme-main/assets/custom.css /var/www/homer/assets/custom.css
cp homer-theme-main/assets/wallpaper.jpeg /var/www/homer/assets/wallpaper.jpeg
cp homer-theme-main/assets/wallpaper-light.jpeg /var/www/homer/assets/wallpaper-light.jpeg
cp -R homer-theme-main/assets/fonts /var/www/homer/assets/
rm -R homer-theme-main

ah it’s request about to update our online docs. This was not clear to me. And it is to add the wallpaper-light.jpeg only. Correct?

Yes.
I created a PR: Homer: Wrong capitalization lead to copy error when trying to apply MacOS theme. by JappeHallunken · Pull Request #829 · MichaIng/DietPi-Docs · GitHub

1 Like

This is only regarding the Diet Pi Docs, not the installation of the theme itself.

I actually had to include the /tmp within the path for some reason, even though I was already in that directory. Not sure why, but it could have been a fluke.

Just to be clear, the capitalization was causing issues, and since I noticed that the wallpaper-light.jpeg was available to use, but wasn’t included in the cp commands within the docs, I added it to the commands as well. Very low priority, of course.

Thanks.