Jappe
February 20, 2023, 1:30pm
2
Did it also remain after a reboot?
I’m not sure if I rebooted directly after the uninstall using dietpi-software. But I did once I tweaked some overclock settings and it remained.
The same thing is happening on my Raspberry Pi 2. I used PiHole there, liked AdGuardHome better so I migrated to that and now I am migrating that AdGuardHome to my Raspberry Pi 1 since I am running out of RAM on my Rpi2.
Screenshot of Rpi2 where I haven’t deleted pihole-FTL.service manually yet:
Probably an issue we might need to report to PiHole developer directly. It’s their service and usually they need to remove it as well.
I guess @MichaIng knows because he supported PiHole developer on implementing this feature.
I guess when the systemd unit was added, it was forgotten to be added to the uninstaller as well. Since I added the systemd unit, my fault
pi-hole:development ← MichaIng:patch-1
opened 08:50PM - 21 Feb 23 UTC
## Thank you for your contribution to the Pi-hole Community!
Please read the … comments below to help us consider your Pull Request.
We are all volunteers and completing the process outlined will help us review your commits quicker.
**Please make sure you**
1. Base your code and PRs against the repositories developmental branch.
2. [Sign Off](https://docs.pi-hole.net/guides/github/how-to-signoff/) all commits as we enforce the [DCO](https://docs.pi-hole.net/guides/github/dco/) for all contributions
3. [Sign](https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits) all your commits as they must have verified signatures
4. File a pull request for any change that requires changes to [our documentation](https://docs.pi-hole.net/) at our [documentation repo](https://github.com/pi-hole/docs)
---
**What does this PR aim to accomplish?:**
Remove the FTL systemd service and override configs on uninstall.
**How does this PR accomplish the above?:**
`rm -(R)f` like other files and dirs.
**Link documentation PRs if any are needed to support this PR:**
None
---
**By submitting this pull request, I confirm the following:**
1. I have read and understood the [contributors guide](https://docs.pi-hole.net/guides/github/contributing/), as well as this entire template. I understand which branch to base my commits and Pull Requests against.
2. I have commented my proposed changes within the code and I have tested my changes.
3. I am willing to help maintain this change if there are issues with it later.
4. It is compatible with the [EUPL 1.2 license](https://opensource.org/licenses/EUPL-1.1)
5. I have squashed any insignificant commits. ([`git rebase`](http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html))
6. I have checked that another pull request for this purpose does not exist.
7. I have considered, and confirmed that this submission will be valuable to others.
8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
9. I give this submission freely, and claim no ownership to its content.
---
- [x] I have read the above and my PR is ready for review. *Check this box to confirm*
Ok. Was it fine to just delete the pihole-FTL.service or did I have to remove those override configs as well?
simply go to remove the override config directory. To be on save side.
rm -Rf /etc/systemd/system/pihole-FTL.service.d
Thanks, that folder wasn’t there anymore. I’m not sure if I deleted it myself or if it was gone with the uninstall using dietpi-software.
It’s an optional folder, not necessarily available on all systems. Typically, it just become available if you create overrides yourself.
or if you do tweaks with dietpi-services. Without the service file itself, the override config dir does no harm, so this is just for complete cleanup.
(despite reviewers from Pi-hole team could/should have recognised as well).