Cleaned up default smb.conf Topic is solved

Suggestions for features and software you would like to see in DietPi, goes here.
Post Reply
Acriax

Cleaned up default smb.conf

Post by Acriax »

This is not a huge thing, just a tiny annoyance that should be pretty easy to fix. Basically, after running the diet-config with Samba added, the smb.conf has a couple of conflicting and unnecessary lines. For example, it has "guest ok = no" and "public = yes", but public is a synonym to guest ok according to https://www.samba.org/samba/docs/man/ma ... onf.5.html. And since they have different values here, it's a bit ambiguous which one takes precedence. Likewise, it has both writeable = yes and read_only = no, and read_only is an inverse synonym for writeable.

But yeah, that's all. :)
User avatar
Fourdee
Site Admin
Posts: 2788
Joined: Tue Feb 06, 2007 1:36 pm

Re: Cleaned up default smb.conf

Post by Fourdee »

Excellent spots.

Have you tested Samba server with the options removed as you mentioned?
If you find our project or support useful, then we’d really appreciate it if you’d consider contributing to the project however you can.
Donating is the easiest – you can use PayPal or become a DietPi patron.
Acriax

Re: Cleaned up default smb.conf

Post by Acriax »

Yes, it works without problem!
User avatar
Fourdee
Site Admin
Posts: 2788
Joined: Tue Feb 06, 2007 1:36 pm

Re: Cleaned up default smb.conf

Post by Fourdee »

Acriax wrote:Yes, it works without problem!
Excellent! Will take a look: https://github.com/Fourdee/DietPi/issues/522
If you find our project or support useful, then we’d really appreciate it if you’d consider contributing to the project however you can.
Donating is the easiest – you can use PayPal or become a DietPi patron.
Post Reply