Page 1 of 1

Cleaned up default smb.conf

Posted: Sun Sep 18, 2016 12:47 pm
by Acriax
This is not a huge thing, just a tiny annoyance that should be pretty easy to fix. Basically, after running the diet-config with Samba added, the smb.conf has a couple of conflicting and unnecessary lines. For example, it has "guest ok = no" and "public = yes", but public is a synonym to guest ok according to https://www.samba.org/samba/docs/man/ma ... onf.5.html. And since they have different values here, it's a bit ambiguous which one takes precedence. Likewise, it has both writeable = yes and read_only = no, and read_only is an inverse synonym for writeable.

But yeah, that's all. :)

Re: Cleaned up default smb.conf

Posted: Mon Sep 19, 2016 2:19 pm
by Fourdee
Excellent spots.

Have you tested Samba server with the options removed as you mentioned?

Re: Cleaned up default smb.conf

Posted: Tue Sep 20, 2016 11:30 am
by Acriax
Yes, it works without problem!

Re: Cleaned up default smb.conf

Posted: Tue Sep 20, 2016 10:38 pm
by Fourdee
Acriax wrote:Yes, it works without problem!
Excellent! Will take a look: https://github.com/Fourdee/DietPi/issues/522